Differences

This shows you the differences between two versions of the page.

Link to this comparison view

irc:1430604000 [2017/05/27 13:44] (current)
Line 1: Line 1:
 +
 +
 +[10:20:33] <​andyhedges>​ Thanks @ AlexLehm, I've configured SLF4J so I'll have to look at what I've done to surpress the messages I want.
 +
 +[10:32:14] <​AlexLehm>​ andyhedges, it should be WARN io.vertx.core.impl.BlockedThreadChecker$1
 +
 +[10:38:13] <​andyhedges>​ thanks AlexLehm
 +
 +[11:05:33] <​andyhedges>​ Looking at this https://​github.com/​eclipse/​vert.x/​blob/​master/​src/​main/​java/​io/​vertx/​core/​impl/​BlockedThreadChecker.java
 +
 +[11:05:49] <​andyhedges>​ it would seem you only get the stack trace after 5 seconds
 +
 +[11:06:37] <​andyhedges>​ and it's pushed to the console
 +
 +[11:08:15] <​AlexLehm>​ it will give warning 3 or 4 times without the stacktrace and then one with stacktrace
 +
 +[11:11:42] <​AlexLehm>​ actually the stack trace is not logged, its printed to System.out
 +
 +[11:15:46] <​andyhedges>​ Yes, as I said pushed to the console, can't be sent to log, which isn't too much of a problem. Also though it would be nice to tune the 5 seconds down.
 +
 +[11:21:34] <​AlexLehm>​ currently that is not configurable I think
 +
 +[11:21:56] <​AlexLehm>​ the warning threshold is, but the stacktrace threshold isn't it seems
 +
 +[11:29:23] <​andyhedges>​ yes agreed
 +
 +[11:29:34] <​andyhedges>​ I've also discovered by logging won't go to SLF4J
 +
 +[11:32:13] <​andyhedges>​ Yeah, the java doc states the override property for the logging delegate is io.vertx.logger-delegate-factory-class-name https://​github.com/​eclipse/​vert.x/​blob/​master/​src/​main/​java/​io/​vertx/​core/​logging/​Logger.java
 +
 +[11:34:40] <​andyhedges>​ but in actual fact the LoggerFactory uses vertx.logger-delegate-factory-class-name https://​github.com/​eclipse/​vert.x/​blob/​master/​src/​main/​java/​io/​vertx/​core/​logging/​impl/​LoggerFactory.java
 +
 +[11:34:46] <​andyhedges>​ without the prefix io
 +
 +[11:52:51] <​andyhedges>​ I've filed a bug
 +
 +[12:02:10] <​AlexLehm>​ ok
 +
 +[12:02:27] <​AlexLehm>​ if you like i can propose a change for the blocking checker to be configurable
 +
 +[12:30:41] <​andyhedges>​ Yeah, that would be useful and log to the logger rather than System.out
 +
 +[13:39:13] <​AlexLehm>​ dang, missed adding the description for a bz ticket, i assume this cannot be edited
 +
 +[13:44:53] <​AlexLehm>​ ok, feel free to add anything to the issue https://​bugs.eclipse.org/​bugs/​show_bug.cgi?​id=466228
 +
 +[15:10:59] <​andyhedges>​ Thanks for that looks good, although I suppose it doesn'​t need to be the same as warning threshold
 +
 +[15:33:22] <​AlexLehm>​ yes i will make it into a property
 +
 +[15:36:59] <​andyhedges>​ :)
 +
 +[15:38:08] <​AlexLehm>​ my excuse if usually, English is not my 1st language, so the ticket description is probably not quite correct
 +
 +[16:06:39] <​andyhedges>​ Ha, I'm impressed by anyone who can speak another language.
 +
 +[16:07:04] <​andyhedges>​ I was thinking it would probably worth adding a tab before each of the stack elements
 +
 +[16:07:12] <​andyhedges>​ it will make it much more readable
 +
 +[16:21:21] <​AlexLehm>​ i think its up to the logger implementation to format the stack trace
 +
 +[16:21:25] <​AlexLehm>​ currently it looks like this
 +
 +[16:23:08] <​AlexLehm>​ http://​pastebin.com/​xTCbtPeB
 +
 +[16:23:18] <​AlexLehm>​ using jul i think
 +
 +[16:46:45] <​AlexLehm>​ hm, i wonder how you could unit test logging changes
 +
 +[16:55:46] <​andyhedges>​ Looks good
 +
 +[16:56:28] <​andyhedges>​ I guess you want to check something gets logged after the designated time
 +
 +[16:59:56] <​AlexLehm>​ yes, but i have to capture the log output somehow
 +
 +[17:00:28] <​AlexLehm>​ i now have 100% coverage of the class, but it doesn'​t really check anything
 +
 +[17:15:18] <​AlexLehm>​ ok, commit my changes, if you want to give it a try https://​github.com/​alexlehm/​vert.x/​tree/​bz466228
 +
 +[18:32:40] <​AlexLehm>​ ok, i created a pull request https://​github.com/​eclipse/​vert.x/​pull/​1028,​ if anybody could look at it
 +
 +[23:17:00] <​aboudreault>​ I see the vert.x 3 doc doesn'​t mention python. Is it at least in progress?
 +
 +[23:26:19] <​AlexLehm>​ that is on the road for 3.1 i think
 +
 +[23:26:46] <​aboudreault>​ ok cool
 +
 +[23:28:37] <​AlexLehm>​ https://​github.com/​vert-x3/​wiki/​wiki/​Vert.x-Roadmap#​vertx-31
 +
 +[23:28:46] <​AlexLehm>​ actually its with ?
 +
 +[23:29:19] <​aboudreault>​ umm. at least scala is listed. \o/