This version (2017/05/27 13:44) is a draft.
Approvals: 0/1

[03:11:14] <voidDotClass>

[03:11:17] <voidDotClass> any thoughts?

[07:59:18] <basky> Hi all. I have developing in vertx 2 and have't used RX for now. Most of my codes endup in callback hell… any ideas how to tackle calback hell .. Also are there any design patterns especially for Async programming ?

[11:51:55] <Narigo> purplefox, about the pull request in mysql-postgresql you just merged: I could not add a real test for this problem as the logging just happens in the database log itself. Do you have an idea how to test this?

[11:54:21] <purplefox> could you replicate the issue?

[12:03:12] <Narigo> purplefox, yes, I could see it in the database logs and see that it went away after changing the code

[12:05:01] <Narigo> all tests still passed and the warning went away in the db. but i saw no direct feedback from the database other than the logging - and the logs can be anywhere :)

[12:06:12] <purplefox> as long as you have a test that replicates it and the test passes after the fix that's fine

[12:08:29] <purplefox> according to your fix the issue was due to the fact that previously the client wasn't setting the inTransaction flag to false, so it should be pretty easy to write a test that asserts the value of this flag during the test, so it fails before your fix and passes after

[12:58:19] <AlexLehm> purplefox: about the shared service, i haven't started on that (i was kind of thinking that is not very useful for the mail client), if we have a shared service the pool will be a single pool for all client instances using the same config, would it be useful to have both (shared/unshared) or is a shared instance enough

[12:59:30] <purplefox> not sure i follow

[12:59:40] <purplefox> why do you think it is not useful?

[12:59:41] <AlexLehm> I may have not considered all use cases for this though

[13:00:55] <AlexLehm> each all to create will “own” a connection pool, but the created instance can be used everywhere if you want to share the pool

[13:01:34] <purplefox> ?

[13:01:59] <AlexLehm> each call to create sorry

[13:02:21] <purplefox> no, the current implementation creates a new pool each time. it does not share anything

[13:02:27] <purplefox> that's the point

[13:02:42] <purplefox> not sure what you mean by “but the created instance can be used everywhere if you want to share the pool”

[13:04:01] <purplefox> sorry, i don't understand the point you're making here, i guess I am being slow :(

[13:04:54] <AlexLehm> I would store the mailclient somewhere “global” and use if in different places, sortof like a singleton

[13:05:46] <AlexLehm> maybe that is not a good idea?

[13:05:52] <purplefox> that's the whole point of the shared stuff

[13:06:17] <purplefox> did you take a look at how we do this in mongo/jdbc? it might make it a bit clearer

[13:09:25] <Narigo> purplefox, thanks for the suggestion. I'll have a look into it - the flag is just for internal use, so you shouldn't really be able to read it outside of that class.. hmm

[13:10:00] <AlexLehm> i will take a look, i have to go now

[23:03:35] <AlexLehm> is really cool, it reacts to the changes of the github issues