Differences

This shows you the differences between two versions of the page.

Link to this comparison view

irc:1464991200 [2017/05/27 13:44] (current)
Line 1: Line 1:
 +[16:12:12] *** ChanServ sets mode: +o temporalfox
 +
 +[18:43:58] *** ChanServ sets mode: +o temporalfox
 +
 +[19:18:08] <​AlexLehm>​ temporalfox:​ Julien, I noticed you write "an HTTP connection"​ in the docu, which I assume should be "a HTTP connection"​
 +
 +[19:18:28] <​temporalfox>​ ah really ?
 +
 +[19:18:39] <​temporalfox>​ feel free to correct me
 +
 +[19:19:29] <​AlexLehm>​ maybe we should ask Tim, he's a native English speaker
 +
 +[19:19:38] <​Sticky> ​  ​depends on the context
 +
 +[19:19:47] <​Sticky>​ will need the full sentance
 +
 +[19:20:04] <​AlexLehm>​ I thought this is based on whether the next word starts with a consonant
 +
 +[19:20:09] <​AlexLehm>​ let me check
 +
 +[19:21:09] <​AlexLehm>​ this line for example https://​github.com/​eclipse/​vert.x/​blob/​master/​src/​main/​java/​io/​vertx/​core/​net/​package-info.java#​L682
 +
 +[19:21:48] <​Sticky>​ the line "The {@link io.vertx.core.net.NetClient} supports configuring an HTTP/1.x _CONNECT_ proxy or _SOCKS4a_ or _SOCKS5_ proxy" ?
 +
 +[19:23:09] <​AlexLehm>​ yes
 +
 +[19:23:29] <​Sticky>​ I believe "​an"​ is correct
 +
 +[19:23:33] <​AlexLehm>​ ok
 +
 +[19:24:04] <​Sticky>​ its a bit weired due to using "​or"​ twice
 +
 +[19:29:02] <​AlexLehm>​ when I initally wrote that I used something CONNECT or SOCKS 4a / 5 (or something like that), I change the first to a comma
 +
 +[19:29:16] <​AlexLehm>​ style is not my strong suit in english
 +
 +[19:29:36] <​Sticky>​ think the better way to phrase it would be "The netclient supports either a HTTP/​1.x__CONNECT__,​ _SOCKS4a_ or _SOCKS5_ proxy"
 +
 +[19:35:07] <​AlexLehm>​ ok, i see how that happened, the same line is in the http docu and that is a bit longer and I added the part about SOCKS afterwards
 +
 +[19:35:49] <​AlexLehm>​ https://​github.com/​eclipse/​vert.x/​blob/​master/​src/​main/​java/​io/​vertx/​core/​http/​package-info.java#​L1594