This version (2017/05/27 13:44) is a draft.
Approvals: 0/1

[00:12:05] <AlexLehm> I have added an option to return error to the test proxy and written the unit test for the issue https://github.com/alexlehm/vert.x/tree/issues/%231489-reproducer-only

[00:53:19] <AlexLehm> temporal_: I think I found the issue, there is a exceptionCaught method in ChannelInboundHandlerAdapter that has to be used to pass the exception to the exception handler

[08:08:06] * ChanServ sets mode: +o temporalfox [09:02:56] * ChanServ sets mode: +o temporalfox

[13:01:38] <AlexLehm> temporalfox: I didn't get the fix finished last night, if that is ok for the timing, I can do it this evening

[13:01:47] <temporalfox> it will be ok

[13:02:06] <AlexLehm> ok, great

[13:02:18] <temporalfox> how about the PR for DNS ?

[13:03:08] <AlexLehm> ah, i didnt look at that last night, i can do it this evening as well

[13:03:14] <AlexLehm> sorry

[13:04:10] <temporalfox> n/p

[14:18:25] <temporalfox> AlexLehm still there ?

[22:16:36] *** ChanServ sets mode: +o temporal_

[23:02:01] <AlexLehm> temporal_: I have created a pr for the fix of the proxy issue https://github.com/eclipse/vert.x/pull/1497

[23:02:08] <temporal_> awesome

[23:02:14] <temporal_> will check after another bug :-)

[23:02:28] <AlexLehm> that was a very small fix, but still an important bug :-)

[23:03:22] <temporal_> yep

[23:03:35] <temporal_> all these little things we miss sometimes

[23:03:50] <temporal_> we're human after all :-)

[23:03:53] <AlexLehm> well yes

[23:33:04] <AlexLehm> I have figure out why I accidentally created test classes that were not run by Surefire (which I had a problem with shortly before the release of 3.3.0)

[23:33:48] <AlexLehm> when copying a java file with eclipse, it suggests the name Classname2.java, which means I copied a test file SomethingTest.java to SomethingTest2.java and didn't notice that

[23:46:53] <temporal_> so now I can look at your PR :-)

[23:47:21] <temporal_> have you reviewed the DNS PR AlexLehm ?

[23:47:51] <AlexLehm> yes almost finished

[23:52:41] <temporal_> I've done a couple of comments on PR